-
Notifications
You must be signed in to change notification settings - Fork 228
update cni version to 1.0.1 #903
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Juan Calderon-Perez <835733+gaby@users.noreply.github.com>
👍🏻 For this, I couldnt get my builds pass for #863 |
@gaby think I got the builds to pass now. I am not sure how to debug the e2e tests as I do not really use ignite. I came here trying to update cni version for containerlabs. Any help would be appreciated. Also I am unsure what snyk is complaining about as I cannot access the details. |
@chanwit @darkowlzz @stealthybox any updates on this? |
Hi @abn and @gaby , sorry for the late response. Before we update CNI, we'll have to bring back ignite to a good shape. Thanks for pushing this forward. |
Hi, I tried updating the unrelated dependencies first and when I updated containerd, it also updates CNI to v1, which also required updating firacracker-go-sdk, as the old version no longer worked with new CNI, and everything else. So at the end, I ended up with everything that's in this PR. I'd like to know the reason for changing |
github.com/stretchr/testify v1.6.1 | ||
github.com/vishvananda/netlink v1.1.0 | ||
github.com/stretchr/testify v1.7.0 | ||
github.com/vishvananda/netlink v1.1.1-0.20220224135417-f7fd7af4377d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be v1.2.0-beta
now.
This builds on top of the work done by @gaby in #863.
Closes: #863